Run Runic on the disco-optimizations files - #4064
Conversation
The disco-optimizations merge (SciML#3720) landed three files that Runic rejects, so format-check has been failing on master for every PR since. Whitespace and line wrapping only; `runic --check .` is clean across the repo afterwards. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DKB6v14nZHZPYtKiLsPLDT
0172415 to
5c05be4
Compare
|
Rebase/validation checkpoint for head
The #4066 commit remains test-only validation context and is not included in this branch. |
|
Clean-master bisect refinement (independent checkout at
This confirms #4064 is the existing focused fix for the complete clean-master formatter regression; no duplicate PR was opened. |
|
One-hour terminal CI audit for rebased head Exact breakdown:
The actual formatting checks are green: hosted |
Please ignore until reviewed by @ChrisRackauckas.
Motivation
The DISCO optimization merge (#3720) left three files that Runic rejects, so
format-checkfails on currentmasterand on every PR based on it.The aggregate whole-tree failure begins at
408a7a30fe. Per-file bisects placedisco.jlanddisco_tests.jlat that commit andintegrators/controllers.jlat80d7e74c82; the relevant files at parentc538565b25all pass.What this does
Runs Runic on exactly the three affected files:
lib/OrdinaryDiffEqCore/src/disco.jllib/OrdinaryDiffEqCore/src/integrators/controllers.jltest/Integrators_I/disco_tests.jlThe diff contains only Runic's whitespace, line-wrapping, numeric-literal, and
explicit-return normalization. There is no behavioral or public-API change.
Formatting exact clean master produces the same 38-insertion/34-deletion tree
as this PR.
Local validation
At rebased head
5c05be4605on upstreamb22e2e58b2:--check ., exit 0)git diff --check: passgit range-diffagainst the prior PR commit: exact (=)GROUP=Integrators_Ion the coherent#4064 + #4066validationstack: Step Limiter 251/251, DISCO 28/28, package tests passed in 2882.56 s
The #4066 compatibility commit is validation-only context and is not included
in this branch. An independent
#3985 + #4066 + #4064validation also passedhomotopy tests 38/38, default nonlinear-solve tests 16/16, whole-tree Runic,
and
git diff --check.Hosted CI
At the one-hour terminal audit, hosted Runic, Runic suggestions, and Typos were
green. The remaining 241 failures all stopped before tests: 127 sublibrary
setup jobs, 44 root setup jobs, 12 downstream resolvers, documentation, and 57
downgrade resolvers. Representative setup logs report the separate SciMLBase
3.39/3.40 boundary fixed by #4066; the downgrade jobs stop inside their
resolver. No hosted failure is in this formatting diff.
No version bump is needed for a formatting-only change.
Checklist
git diff --checkpass